tripodsan commented on a change in pull request #137:
URL:
https://github.com/apache/jackrabbit-filevault/pull/137#discussion_r633274636
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java
##########
@@ -257,7 +250,9 @@ public ImportInfoImpl accept(WorkspaceFilter wspFilter,
Node parent,
path = path.substring(idx + 1);
}
// only update binary if import mode is not MERGE
- if (wspFilter.getImportMode(parentNode.getPath()) !=
ImportMode.MERGE) {
+ // TODO: why? if not existing yet even with merge should be
set afterwards
Review comment:
well, merge must not modify the property. since the binary property is
required on the file, it doesn't need to be processed here (i think :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
