stoerr commented on a change in pull request #144:
URL:
https://github.com/apache/jackrabbit-filevault/pull/144#discussion_r646874602
##########
File path:
vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/impl/PackagePropertiesImplTest.java
##########
@@ -93,9 +94,6 @@ public void testDateFormat() {
checkDateParsing("2021-05-26T15:12:21.673+0200","2021-05-26T13:12:21.673Z");
checkDateParsing("2021-05-26T15:12:21.673-0230","2021-05-26T17:42:21.673Z");
- // missing timezone is treated as UTC. TODO is that right?
- checkDateParsing("2021-05-26T15:12:21.673","2021-05-26T15:12:21.673Z");
-
Review comment:
What happens now if the timezone is missing? I don't know whether
anything produces that date format, but at least I'm a fan of specifying such
edge cases in the test, even if the documentation doesn't really say anything
about that. Not sure whether it's a problem if that behavior changes. That
throws an exception now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
