[
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363727#comment-17363727
] Konrad Windszus edited comment on JCRVLT-509 at 6/15/21, 3:56 PM: ------------------------------------------------------------------ We do already have a list of properties which are protected (https://github.com/apache/jackrabbit-filevault/blob/e02261b108aa4dd65fdd386b1b892d8eb8685c12/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L142) and in addition ones which should be ignored in addition during import at https://github.com/apache/jackrabbit-filevault/blob/e02261b108aa4dd65fdd386b1b892d8eb8685c12/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L148. But in any case failure to set a property should be gracefully handled (https://github.com/apache/jackrabbit-filevault/blob/e02261b108aa4dd65fdd386b1b892d8eb8685c12/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L1174). Please add an IT (preferably together with a fix) as PR. was (Author: kwin): We do already have a list of properties which are protected (https://github.com/apache/jackrabbit-filevault/blob/e02261b108aa4dd65fdd386b1b892d8eb8685c12/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L142) and in addition ones which should be ignored in addition during import at https://github.com/apache/jackrabbit-filevault/blob/e02261b108aa4dd65fdd386b1b892d8eb8685c12/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L148. Please add an IT (preferably together with a fix) as PR. > Make DocView import failures fail the whole installation > -------------------------------------------------------- > > Key: JCRVLT-509 > URL: https://issues.apache.org/jira/browse/JCRVLT-509 > Project: Jackrabbit FileVault > Issue Type: Improvement > Affects Versions: 3.4.10 > Reporter: Konrad Windszus > Assignee: Konrad Windszus > Priority: Major > Fix For: 3.5.0 > > > Currently all ACL, authorizable and regular node exceptions are caught in > https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683 > and just logged. Afterwards the import of the package just continues. Only > in case the ImportOptions.setStrict() is set to {{true}} it will lead to a > PackageException in the end. -- This message was sent by Atlassian Jira (v8.3.4#803005)
