[ 
https://issues.apache.org/jira/browse/JCRVLT-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369535#comment-17369535
 ] 

Konrad Windszus commented on JCRVLT-542:
----------------------------------------

I proposed a slightly different fix in 
https://github.com/apache/jackrabbit-filevault/pull/153 (to make sure primary 
type adjustment don't appear with mode UPDATE* either) which also makes sure 
that the primary type adjustment is correctly tracked.

> FolderArtifactHandler not respecting ImportMode on adjusting primaryTypes
> -------------------------------------------------------------------------
>
>                 Key: JCRVLT-542
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-542
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>    Affects Versions: 3.4.4
>            Reporter: Dominik Süß
>            Assignee: Konrad Windszus
>            Priority: Critical
>             Fix For: 3.5.2
>
>
> By definition mode=merge or the new mode=merge_properties should never modify 
> existing nodes/properties for the corresponding filters. It turns out that 
> this check is  missing for the adjustments of primaryNodeTypes which boldly 
> breaks where the parent structures are assumed to be preexisting (like 
> /home/groups) and just covered by folders without any nodetype declared - the 
> existing logic does reset those to the default nt:folder which leads to a 
> broken commit due to nodeType incompatibilities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to