[
https://issues.apache.org/jira/browse/JCRVLT-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372122#comment-17372122
]
Konrad Windszus edited comment on JCRVLT-544 at 6/30/21, 5:16 PM:
------------------------------------------------------------------
bq. The change of JCRVLT-417 creates regressions; it is unclear to me whether
that change is trying to fix a theoretical or practical problem. If it is
theoretical we could think about reverting.
Please read the description of JCRVLT-417 and also
https://issues.apache.org/jira/browse/JCRVLT-413?focusedCommentId=17039756&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17039756
bq. try without specifying a nodetype, if that fails, provide a default one.
We do that already, compare with
https://github.com/apache/jackrabbit-filevault/blob/4590f8f71b01e51fe2faaec26f86fa5af2a5c8e8/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FolderArtifactHandler.java#L87
bq. Shouldn't it be possible to inspect the node type and see if a default
child node type is specified?
Yes, we do that already, but as described in this issue, {{cq:Component}}
defines a default child node, but of the wrong type.
was (Author: kwin):
bq. The change of JCRVLT-417 creates regressions; it is unclear to me whether
that change is trying to fix a theoretical or practical problem. If it is
theoretical we could think about reverting.
Please read the description of JCRVLT-417 an also
https://issues.apache.org/jira/browse/JCRVLT-413?focusedCommentId=17039756&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17039756
bq. try without specifying a nodetype, if that fails, provide a default one.
We do that already, compare with
https://github.com/apache/jackrabbit-filevault/blob/4590f8f71b01e51fe2faaec26f86fa5af2a5c8e8/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FolderArtifactHandler.java#L87
bq. Shouldn't it be possible to inspect the node type and see if a default
child node type is specified?
Yes, we do that already, but as described in this issue, {{cq:Component}}
defines a default child node, but of the wrong type.
> Creation of folders based on parent nodetype instead of nt:folder causing
> regression
> ------------------------------------------------------------------------------------
>
> Key: JCRVLT-544
> URL: https://issues.apache.org/jira/browse/JCRVLT-544
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
> Affects Versions: 3.4.4
> Reporter: Dominik Süß
> Assignee: Konrad Windszus
> Priority: Major
>
> The change of JCRVLT-417 makes folder creation fall back to the nodetypes
> declared in the nodetype constraint of the primary type. This can cause
> regressions with existing packages.
> In the given case the nodetype cq:Component allows a child node definition
> with primaryType nt:base (which nt:folder derives from) - yet as nt:base has
> no childNodeDefinitions declared any substructures fail to install. The
> nodeType definition of cq:Component is correct as it "allows" anything
> deriving from nt:base, whereas only the derived nodeTypes open up further
> options like substructures.
> //cc [~kwin] introducing the behavioral change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
