fabriziofortino commented on a change in pull request #309:
URL: https://github.com/apache/jackrabbit-oak/pull/309#discussion_r662329602



##########
File path: 
oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/PersistentDiskCache.java
##########
@@ -213,6 +219,23 @@ private void cleanUpInternal() {
         }
     }
 
+    private class SegmentCacheEntry {

Review comment:
       cosmetics: since this class is internal, we could have the members as 
`public final` and remove the getters to be more concise. Moreover, the class 
should be `static`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to