nit0906 commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687632433
##########
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##########
@@ -1050,6 +1051,7 @@ public void done(String now) {
}
public void failed(Exception e) {
+ boolean isConcurrentUpdateException = (e.getMessage() != null) &&
(e.getMessage().startsWith(CONCURRENT_EXCEPTIPN_MSG));
Review comment:
@thomasmueller
e instanceof ConcurrentUpdateException -> Actually it's not
ConcurrentUpdateException but rather CommitFailedException - see
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java#L1557#L1559
And CommitFailedException is more generic so I didn't want to make use of
instanceOf.
I will make it multi line though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
