thomasmueller commented on a change in pull request #351:
URL: https://github.com/apache/jackrabbit-oak/pull/351#discussion_r698261868
##########
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java
##########
@@ -72,6 +73,9 @@
private static final Logger log =
LoggerFactory.getLogger(IndexUpdate.class);
private static final String TYPE_ELASTICSEARCH = "elasticsearch";
+ //This is used so that wrong index definitions are sparsely logged. After
every 1000 indexing cycles with diff, wrong index definitions
Review comment:
By default the indexing cycle is once every 5 seconds. That mean 5000
seconds, or 83 minutes. I think that's a good value.
##########
File path:
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java
##########
@@ -72,6 +73,9 @@
private static final Logger log =
LoggerFactory.getLogger(IndexUpdate.class);
private static final String TYPE_ELASTICSEARCH = "elasticsearch";
+ //This is used so that wrong index definitions are sparsely logged. After
every 1000 indexing cycles with diff, wrong index definitions
Review comment:
And for sync indexes, once in 1000 updates is fine as well I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
