[ 
https://issues.apache.org/jira/browse/JCRVLT-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated JCRVLT-560:
-----------------------------------
    Description: 
In contrast to JCR 2.0 DocView which states
bq. If P is a BINARY property its value is Base64 encoded. The resulting string 
becomes the value of the XML attribute P.
(https://docs.adobe.com/content/docs/en/spec/jcr/2.0/7_Export.html#7.3%20Document%20View)
 the binary support in FileVault DocView uses the default conversion from 
String to UTF-8 byte array encoding for multi-value properties in 
https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L500
  
(https://docs.adobe.com/content/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.6.4.1%20From%20STRING%20To)
 or only binary references for single values: 
https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L519.

For {{.binary}} files there is multi-value support during export in 
https://github.com/apache/jackrabbit-filevault/blob/0087391e3e2dbe0f70fab5dcb1a283c354c13c25/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/PropertyValueArtifact.java#L118-L124
 but no proper support during import 
https://github.com/apache/jackrabbit-filevault/blob/0087391e3e2dbe0f70fab5dcb1a283c354c13c25/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L247-L270

This difference is currently not explained in 
https://jackrabbit.apache.org/filevault/docview.html and the handling is 
inconsistent between single- and multi-value.

  was:
In contrast to JCR 2.0 DocView which states
bq. If P is a BINARY property its value is Base64 encoded. The resulting string 
becomes the value of the XML attribute P.
(https://docs.adobe.com/content/docs/en/spec/jcr/2.0/7_Export.html#7.3%20Document%20View)
 the binary support in FileVault DocView uses the default conversion from 
String to UTF-8 byte array encoding for multi-value properties in 
https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L500
  
(https://docs.adobe.com/content/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.6.4.1%20From%20STRING%20To)
 or only binary references for single values: 
https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L519.

This difference is currently not explained in 
https://jackrabbit.apache.org/filevault/docview.html and the handling is 
inconsistent between single- and multi-value.


> Support multi-value binary properties in FileVault DocView and via .binary 
> files
> --------------------------------------------------------------------------------
>
>                 Key: JCRVLT-560
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-560
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: 3.5.4
>
>
> In contrast to JCR 2.0 DocView which states
> bq. If P is a BINARY property its value is Base64 encoded. The resulting 
> string becomes the value of the XML attribute P.
> (https://docs.adobe.com/content/docs/en/spec/jcr/2.0/7_Export.html#7.3%20Document%20View)
>  the binary support in FileVault DocView uses the default conversion from 
> String to UTF-8 byte array encoding for multi-value properties in 
> https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L500
>   
> (https://docs.adobe.com/content/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.6.4.1%20From%20STRING%20To)
>  or only binary references for single values: 
> https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L519.
> For {{.binary}} files there is multi-value support during export in 
> https://github.com/apache/jackrabbit-filevault/blob/0087391e3e2dbe0f70fab5dcb1a283c354c13c25/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/PropertyValueArtifact.java#L118-L124
>  but no proper support during import 
> https://github.com/apache/jackrabbit-filevault/blob/0087391e3e2dbe0f70fab5dcb1a283c354c13c25/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L247-L270
> This difference is currently not explained in 
> https://jackrabbit.apache.org/filevault/docview.html and the handling is 
> inconsistent between single- and multi-value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to