[ 
https://issues.apache.org/jira/browse/JCRVLT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422580#comment-17422580
 ] 

Konrad Windszus commented on JCRVLT-554:
----------------------------------------

The problem is to which phase to bind this goal by default, as it has to be 
executed prior to "generate-metadata". 

As both are right now bound to "process-classes" the order is determined by 
Maven and would require to list both executions in the plugin configurations as 
otherwise the order is wrong. The following options would solve this:
# Bind "generate-metadata" to a later phase (which is still executed in m2e 
incremental builds), e.g. "generate-test-sources", this would require moving 
"validate-files" to that phase or a later one  as well
# Just add a hint in the documentation that once you enable "analyze-classes" 
you have to make sure it runs prior to "generate-metadata" and "validate-files"

I would rather tend to implement option 1. 

> Don't bind "analyze-classes" goal by default
> --------------------------------------------
>
>                 Key: JCRVLT-554
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-554
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.2.0
>
>
> The goal "analyze-classes" is automatically executed for each content-package 
> project by default in phase "process-classes". As the output is currently 
> only included in the MANIFEST.MF but not evaluated by any tool 
> (https://jackrabbit.apache.org/filevault/properties.html#Manifest_File), it 
> should only be executed if explicitly configured.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to