stefan-egli commented on a change in pull request #385:
URL: https://github.com/apache/jackrabbit-oak/pull/385#discussion_r723179376



##########
File path: 
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
##########
@@ -550,6 +550,8 @@ public NodeDocument call() throws Exception {
                 return findUncached(collection, key, docReadPref);
             } catch (MongoException e) {
                 ex = e;
+                LOG.error("Read Fails with an exception" + e);
+                e.printStackTrace();

Review comment:
       would adding the exception stacktrace to the log make sense or is that 
too verbose? (e.printStackTrace() otherwise just prints to standard out)

##########
File path: 
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
##########
@@ -550,6 +550,8 @@ public NodeDocument call() throws Exception {
                 return findUncached(collection, key, docReadPref);
             } catch (MongoException e) {
                 ex = e;
+                LOG.error("Read Fails with an exception" + e);
+                e.printStackTrace();

Review comment:
       ```suggestion
                   LOG.error("findUncachedWithRetry : read fails with an 
exception" + e, e);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to