[
https://issues.apache.org/jira/browse/JCRVLT-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426971#comment-17426971
]
Konrad Windszus commented on JCRVLT-564:
----------------------------------------
There is a typo in
https://github.com/apache/jackrabbit-filevault/blob/42f8aa605855637a81bdb80446564cdc0ded9888/vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/PackageTypeValidatorFactory.java#L72.
The default value for configuration
{{additionalJcrInstallerFileNodePathRegex}} is supposed to be
{{.*\\.(config|cfg|cfg\\.json|jar)}} but instead it is
{{.*\\.(config|cfg|cfg\\\\.json|jar)}}.
> jackrabbit-packagetype validation fails for content package with OSGi
> configurations
> ------------------------------------------------------------------------------------
>
> Key: JCRVLT-564
> URL: https://issues.apache.org/jira/browse/JCRVLT-564
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
> Affects Versions: package-maven-plugin-1.2.0
> Reporter: Stefan Seifert
> Priority: Major
>
> scenario:
> * checkout
> [https://github.com/stefanseifert/filevault-package-maven-plugin-validation-issues]
> * update filevault-package-maven-plugin to 1.2.0
> * try to build the module {{content-packages/osgi-config}}
> * build fails - but package is imho correct and build was fine with version
> 1.1.8
> validation errors:
> {noformat}
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig,
> nodePath=/apps/osgi-config-sample/core-osgiconfig
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config\io.wcm.caconfig.extensions.persistence.impl.PagePersistenceStrategy.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config/io.wcm.caconfig.extensions.persistence.impl.PagePersistenceStrategy.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author\com.adobe.cq.dam.processor.nui.impl.workflow.CustomDamWorkflowRunnerImpl.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author/com.adobe.cq.dam.processor.nui.impl.workflow.CustomDamWorkflowRunnerImpl.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author\com.day.cq.mailer.DefaultMailService.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author/com.day.cq.mailer.DefaultMailService.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author\com.day.cq.workflow.impl.email.EMailNotificationService.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author/com.day.cq.workflow.impl.email.EMailNotificationService.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author\io.wcm.handler.mediasource.dam.impl.dynamicmedia.DynamicMediaSupportServiceImpl.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author/io.wcm.handler.mediasource.dam.impl.dynamicmedia.DynamicMediaSupportServiceImpl.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author\org.apache.felix.hc.core.impl.servlet.HealthCheckExecutorServlet~health.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author/org.apache.felix.hc.core.impl.servlet.HealthCheckExecutorServlet~health.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author.dev,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author.dev
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.author.dev\com.day.cq.commons.servlets.RootMappingServlet.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.author.dev/com.day.cq.commons.servlets.RootMappingServlet.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.dev,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.dev
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.dev\org.apache.sling.caconfig.impl.override.OsgiConfigurationOverrideProvider~siteconfig.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.dev/org.apache.sling.caconfig.impl.override.OsgiConfigurationOverrideProvider~siteconfig.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.prod,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.prod
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.prod\org.apache.sling.caconfig.impl.override.OsgiConfigurationOverrideProvider~siteconfig.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.prod/org.apache.sling.caconfig.impl.override.OsgiConfigurationOverrideProvider~siteconfig.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.publish,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.publish
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.publish\io.wcm.caconfig.editor.impl.EditorConfig.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.publish/io.wcm.caconfig.editor.impl.EditorConfig.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.publish\io.wcm.handler.mediasource.dam.impl.dynamicmedia.DynamicMediaSupportServiceImpl.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.publish/io.wcm.handler.mediasource.dam.impl.dynamicmedia.DynamicMediaSupportServiceImpl.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.publish\org.apache.sling.servlets.get.DefaultGetServlet.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.publish/org.apache.sling.servlets.get.DefaultGetServlet.cfg.json
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.stage,
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.stage
> [ERROR] ValidationViolation: "jackrabbit-packagetype: Package of type
> 'CONTAINER' is not supposed to contain anything but OSGi
> bundles/configurations and subpackages!",
> filePath=jcr_root\apps\osgi-config-sample\core-osgiconfig\config.stage\org.apache.sling.caconfig.impl.override.OsgiConfigurationOverrideProvider~siteconfig.cfg.json,
>
> nodePath=/apps/osgi-config-sample/core-osgiconfig/config.stage/org.apache.sling.caconfig.impl.override.OsgiConfigurationOverrideProvider~siteconfig.cfg.json
> {noformat}
>
> i do not understand why the (valid) osgi configs are not accepted as such.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
