etugarev commented on a change in pull request #378:
URL: https://github.com/apache/jackrabbit-oak/pull/378#discussion_r728941025
##########
File path:
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/util/IndexDefinitionBuilder.java
##########
@@ -624,6 +622,7 @@ private static Tree getOrCreateChild(Tree tree, String
name){
IndexConstants.USE_IF_EXISTS,
IndexConstants.QUERY_PATHS,
IndexConstants.INDEX_TAGS,
+ IndexConstants.INDEX_SELECTION_POLICY,
Review comment:
@thomasmueller @averma21 I agree, there are things to improve (like code
reorganisation), but this was not in scope of this PR. Currently both builders
support it, so this change should be transparent. Also, switching the clients
to a
`org.apache.jackrabbit.oak.plugins.index.search.util.IndexDefinitionBuilder`
would require some additional work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
