averma21 commented on a change in pull request #399:
URL: https://github.com/apache/jackrabbit-oak/pull/399#discussion_r736491476
##########
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexNameHelper.java
##########
@@ -98,8 +75,8 @@ public static String
getRemoteIndexName(ElasticIndexDefinition indexDefinition)
* <p>
* The resulting file name would be truncated to MAX_NAME_LENGTH
*/
- private static String getElasticSafeIndexName(String indexPath) {
- String name = StreamSupport
+ public static String getElasticSafeIndexName(String indexPrefix, String
indexPath) {
+ String name = indexPrefix + "." + StreamSupport
Review comment:
In that case, option 2 is fine and I think instead of comment, adding a
javadoc which clarifies the expectations would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
