tripodsan commented on a change in pull request #163:
URL:
https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747282565
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java
##########
@@ -1295,6 +1297,37 @@ public void endElement(String uri, String localName,
String qName) throws SAXExc
}
}
+ private boolean hasSiblingWithSameType(Node child) throws
RepositoryException {
+
+ Node parent = child.getParent();
+ EffectiveNodeType ent = EffectiveNodeType.ofNode(parent);
+ Optional<NodeDefinition> childDef =
ent.getApplicableChildNodeDefinition(child.getName(),
child.getPrimaryNodeType());
+
+ if (!childDef.isPresent()) {
+ log.debug("no NodeDefinition for {}", child.getPath());
+ } else {
+ String typeName = childDef.get().getDeclaringNodeType().getName();
Review comment:
why is the typename relevant? it's the mandatory type that needs to be
compared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
