kwin edited a comment on pull request #188:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/188#issuecomment-995633441


   > Is there an existing test class that I can extend?
   
   ~~There is 
org.apache.jackrabbit.vault.packaging.registry.impl.FSInstallStateTest (pretty 
obvious, right?)~~
   
   Update: There is no test class yet for FSInstallStateCache, but a test with 
one method should be fairly easy to add.
   
   > and we really really want to finally upgrade
   
   Yes, I am not saying that this blocks the merge, but it has regressed before 
because there were no test covering that. Let's do better this time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to