[
https://issues.apache.org/jira/browse/JCRVLT-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464738#comment-17464738
]
Konrad Windszus commented on JCRVLT-577:
----------------------------------------
There is one thing which needs to be clarified first: What happens with the
root node {{/etc/workflow/launcher/config}} in case there are
includes/excludes. This has also been brought up in the context of JCRVLT-378.
> filter.xml does not delete nodes defined in includes/excludes if folder does
> not exist in content package
> ---------------------------------------------------------------------------------------------------------
>
> Key: JCRVLT-577
> URL: https://issues.apache.org/jira/browse/JCRVLT-577
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin, vlt
> Affects Versions: 3.5.6
> Reporter: Henry Kuijpers
> Priority: Major
>
> Failing test case over here:
> https://github.com/henrykuijpers/jackrabbit-filevault/commit/75ff3d7a6283e78510c87db18ad6d10626dcc4ac
> We have the following filter.xml:
> {code:xml}
> <filter root="/etc/workflow/launcher/config/update_asset_create"/>
> <filter root="/etc/workflow/launcher/config/update_asset_mod"/>
> <filter root="/etc/workflow/launcher/config">
> <include pattern="/etc/workflow/launcher/config/something-.*(/.*)?"/>
> </filter>
> {code}
> The content package is as follows:
> {code:java}
> MB0010:Downloads henrykuijpers$ unzip -l "cleanup.zip"
> Archive: cleanup.zip
> Length Date Time Name
> --------- ---------- ----- ----
> 139 12-15-2021 15:59 META-INF/MANIFEST.MF
> 0 12-15-2021 15:59 META-INF/
> 0 12-15-2021 15:59 META-INF/vault/
> 785 12-15-2021 15:59 META-INF/vault/properties.xml
> 3592 12-15-2021 15:59 META-INF/vault/config.xml
> 179 12-15-2021 15:59 META-INF/vault/filter.xml
> 338 12-15-2021 15:59 jcr_root/.content.xml
> 308 12-15-2021 15:59 META-INF/vault/nodetypes.cnd
> 0 12-15-2021 15:59 META-INF/vault/definition/
> 947 12-15-2021 15:59 META-INF/vault/definition/.content.xml
> {code}
> As you can see, we're not including any content in the content package. Our
> assumption would be that:
> /etc/workflow/launcher/config/update_asset_create is deleted => Works
> /etc/workflow/launcher/config/update_asset_mod is deleted => Works
> /etc/workflow/launcher/config/test is untouched => Works
> /etc/workflow/launcher/config/something-test is deleted => Does not work
> The entries in the "include"-part of the /etc/workflow/launcher/config filter
> are only considered, when the jcr_root/etc/workflow/launcher/config folder is
> present in the content package.
> However, the other 2 entries do cause the expected deletion.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
