stefan-egli commented on a change in pull request #449:
URL: https://github.com/apache/jackrabbit-oak/pull/449#discussion_r779590689
##########
File path:
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/CachingCommitValueResolver.java
##########
@@ -148,7 +149,13 @@ public String resolve(@NotNull Revision changeRevision,
// only cache committed states
// e.g. branch commits may be merged later and
// the commit value will change
- commitValueCache.put(changeRevision, value);
+ try {
+ commitValueCache.put(changeRevision, value);
+ } catch (RuntimeException re) {
+ LoggerFactory.getLogger(getClass()).error("resolve:
RuntimeException with " +
+ changeRevision + " - " + value, re);
+ throw re;
Review comment:
Good point, it probably doesn't matter if that `put` fails - so a
rethrow isnt strictly necessary.
Changed that now
[here](https://github.com/apache/jackrabbit-oak/pull/449/commits/5a7b331af20345d2e75a068fc183cd1b0c1886c8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
