reschke commented on a change in pull request #195:
URL:
https://github.com/apache/jackrabbit-filevault/pull/195#discussion_r781508624
##########
File path:
vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/PackageInstallIT.java
##########
@@ -376,17 +377,17 @@ public void testExternalHookFailsInInstalledPhase()
throws RepositoryException,
assertNodeExists("/testroot");
}
- /**
- * Installs a package with no properties
- */
- @Test
public void testNoProperties() throws RepositoryException, IOException,
PackageException {
- File tmpFile = File.createTempFile("vlttest", "zip");
- IOUtils.copy(getStream("/test-packages/tmp_no_properties.zip"),
FileUtils.openOutputStream(tmpFile));
- JcrPackage pack = packMgr.upload(tmpFile, true, true, "testpackage",
false);
- assertNotNull(pack);
-
- pack.install(getDefaultOptions());
+ File tmpFile = File.createTempFile("avlttest", "zip");
Review comment:
Also, the "try" is still needed so that the output stream gets closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
