kwin commented on a change in pull request #195:
URL:
https://github.com/apache/jackrabbit-filevault/pull/195#discussion_r781541262
##########
File path:
vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/PackageInstallIT.java
##########
@@ -404,14 +411,17 @@ public void testNoProperties() throws
RepositoryException, IOException, PackageE
*/
@Test
public void testNoChildFilter() throws RepositoryException, IOException,
PackageException {
- File tmpFile = File.createTempFile("vlttest", "zip");
- IOUtils.copy(getStream("/test-packages/test-package-with-etc.zip"),
FileUtils.openOutputStream(tmpFile));
- JcrPackage pack = packMgr.upload(tmpFile, true, true,
"test-package-with-etc", false);
- assertNodeExists("/etc");
- admin.getNode("/etc").addNode("foo", NodeType.NT_FOLDER);
- admin.save();
- pack.install(getDefaultOptions());
- assertNodeExists("/etc/foo");
+ File tmpFile = testFolder.newFile();
Review comment:
you can directly use
https://github.com/apache/jackrabbit-filevault/blob/d146b319d8dfd676f8e500468508d491590de2f1/vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/IntegrationTestBase.java#L386.
That prevents copying to a tmpFile in most of the cases.
##########
File path:
vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/PackageInstallIT.java
##########
@@ -381,12 +386,14 @@ public void testExternalHookFailsInInstalledPhase()
throws RepositoryException,
*/
@Test
public void testNoProperties() throws RepositoryException, IOException,
PackageException {
- File tmpFile = File.createTempFile("vlttest", "zip");
- IOUtils.copy(getStream("/test-packages/tmp_no_properties.zip"),
FileUtils.openOutputStream(tmpFile));
- JcrPackage pack = packMgr.upload(tmpFile, true, true, "testpackage",
false);
- assertNotNull(pack);
-
- pack.install(getDefaultOptions());
+ File tmpFile = testFolder.newFile();
Review comment:
you can directly use
https://github.com/apache/jackrabbit-filevault/blob/d146b319d8dfd676f8e500468508d491590de2f1/vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/IntegrationTestBase.java#L386.
That prevents copying to a tmpFile in most of the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
