kwin commented on a change in pull request #202:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786220774



##########
File path: 
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/PackagingImpl.java
##########
@@ -106,6 +106,9 @@ public PackagingImpl() {
 
         @AttributeDefinition(description = "Whether to overwrite the primary 
type of folders")
         boolean overwritePrimaryTypesOfFolders() default true;
+
+        @AttributeDefinition(description = "Default IdConflictPolicy")

Review comment:
       Please use the enum values instead (not free-text String), that also 
prevents type conversion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to