blackfor commented on a change in pull request #467:
URL: https://github.com/apache/jackrabbit-oak/pull/467#discussion_r786847726



##########
File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java
##########
@@ -1201,7 +1201,13 @@ private SelectorExecutionPlan 
getBestSelectorExecutionPlan(
         }
 
         if (potentiallySlowTraversalQuery || bestIndex == null) {
-            LOG.debug("no proper index was found for filter {}", filter);
+            // Log error for fulltext queries without index, since these 
cannot return results
+            if(!filter.getFulltextConditions().isEmpty()) { 
+                LOG.error("Fulltext query without index for filter {}; no 
results will be returned", filter);

Review comment:
       I was unsure on this too; my thinking was that it should be an ERROR 
because the query will _never_ return results - so it's not that it's not 
performant, it's actually effectively failing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to