FrancoisZhang commented on a change in pull request #469:
URL: https://github.com/apache/jackrabbit-oak/pull/469#discussion_r797948129



##########
File path: 
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java
##########
@@ -1551,7 +1551,7 @@ private static Query tokenToQuery(String text, String 
fieldName, PlanResult pr,
         if (FieldNames.FULLTEXT.equals(fieldName)) {
             Query subQuery = new BooleanQuery();
             if (pr.indexDefinition.isDynamicBoostLiteEnabled()) {
-                subQuery = new TermQuery(new Term(FieldNames.SIMILARITY_TAGS, 
text));
+                subQuery = new TermQuery(new Term(FieldNames.SIMILARITY_TAGS, 
text.toLowerCase()));

Review comment:
       @fabriziofortino  I verified it again, tokenToQuery does great to make 
it fully supporting the lucene fulltext query syntax. I made another commit to 
use that instead and added some tests to verify it's query ability. It should 
make more sense here. Only concern is it will make it doesn't match the 
behavior of DynamicBoost in Lucene and Elastic. More like a product decision 
here though. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to