nit0906 commented on a change in pull request #489:
URL: https://github.com/apache/jackrabbit-oak/pull/489#discussion_r803843799
##########
File path:
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticFullTextAsyncTest.java
##########
@@ -264,16 +259,104 @@ public void fulltextWithModifiedNodeScopeIndex() throws
Exception {
test.addChild("a").setProperty("analyzed_field", "sun.jpg");
root.commit();
- assertEventually(() ->
- assertQuery("//*[jcr:contains(@analyzed_field, 'SUN.JPG')] ",
XPATH, Collections.singletonList("/test/a")));
+ assertEventually(() -> assertQuery("//*[jcr:contains(@analyzed_field,
'SUN.JPG')] ", XPATH, Collections.singletonList("/test/a")));
// add nodeScopeIndex at a later stage
- index.getChild("indexRules").getChild("nt:base").getChild("properties")
-
.getChild("analyzed_field").setProperty(FulltextIndexConstants.PROP_NODE_SCOPE_INDEX,
true);
+ index.getChild("indexRules")
+ .getChild("nt:base")
+ .getChild("properties")
+ .getChild("analyzed_field")
+ .setProperty(FulltextIndexConstants.PROP_NODE_SCOPE_INDEX,
true);
Review comment:
Wouldn't we need to reindex if we are changing the index definition
later on in the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
