clotton commented on a change in pull request #204:
URL:
https://github.com/apache/jackrabbit-filevault/pull/204#discussion_r804095833
##########
File path:
vault-core/src/main/java/org/apache/jackrabbit/vault/util/RepositoryCopier.java
##########
@@ -410,11 +410,17 @@ private void copy(AutoSave autoSave, Node src, Node
dstParent, String dstName, b
currentSize+=s;
}
} else {
- Value v = p.getValue();
- dst.setProperty(pName, v);
- long s= p.getLength();
- totalSize+=s;
- currentSize+=s;
+ // Filter out unwanted properties. Remove them from
the destination if they are excluded by filter
Review comment:
Thanks @kwin does the current sysCopy method already filter out nodes
somehow, but it is missing property based filtering? I'm a little lost looking
at the current
[sysCopy](https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/util/RepositoryCopier.java#L505)
having never been in here before. I also have no knowledge of XML parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
