mreutegg commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804802274
##########
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/composite/blueGreen/IndexUtils.java
##########
@@ -142,7 +142,7 @@ public static void checkLibsIsReadOnly(Persistence p)
throws RepositoryException
try {
libsNode.addNode("illegal");
Assert.fail();
- } catch (UnsupportedOperationException e) {
+ } catch (RepositoryException e) {
Review comment:
> This test is not responsible to test the implementation of the JCR, so
it should just rely on the API contract.
Well, currently the test does check an implementation detail. It catches a
UnsupportedOperationException. But you are right the method does not
`UnsupportedOperationException` nor `ConstraintViolationException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
