fabriziofortino commented on a change in pull request #494:
URL: https://github.com/apache/jackrabbit-oak/pull/494#discussion_r807811345



##########
File path: 
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java
##########
@@ -276,6 +276,11 @@ private static void mapIndexRules(ElasticIndexDefinition 
indexDefinition, XConte
             mappingBuilder.endObject();
         }
 
+        mappingBuilder.startObject(ElasticIndexDefinition.DYNAMIC_BOOST_TAGS)
+                .field("type", "text")
+                .field("analyzer", "oak_analyzer")
+                .endObject();
+

Review comment:
       @FrancoisZhang I don't think this works. The mapping field in the 
for-loop overwrites itself since the name is always the same. The name has to 
be composed (see my suggestion above). I would create it with `pd.nodeName + 
FieldNames.FULLTEXT` (you can get rid of DYNAMIC_BOOST_TAGS). This would 
require some changes in `ElasticRequestHandler` since the fields to query need 
to be re-computed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to