smiroslav commented on a change in pull request #500:
URL: https://github.com/apache/jackrabbit-oak/pull/500#discussion_r812693295
##########
File path:
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java
##########
@@ -165,7 +165,8 @@ public void init() throws DataStoreException {
try {
Utils.setProxyIfNeeded(properties);
containerName = (String)
properties.get(AzureConstants.AZURE_BLOB_CONTAINER_NAME);
- createBlobContainer =
PropertiesUtil.toBoolean(properties.getProperty(AzureConstants.AZURE_CREATE_CONTAINER),
true);
+ createBlobContainer =
PropertiesUtil.toBoolean(properties.getProperty(AzureConstants.AZURE_CREATE_CONTAINER),
true)
+ &&
PropertiesUtil.toString(properties.getProperty(AzureConstants.AZURE_SAS),
"").isEmpty();
Review comment:
I think it should rather be controlled with property
`azureCreateContainer`. Code here assumes that SAS toke is generated for
container, but it can be account level toke as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
