thomasmueller commented on a change in pull request #516:
URL: https://github.com/apache/jackrabbit-oak/pull/516#discussion_r826023915



##########
File path: 
oak-run/src/main/java/org/apache/jackrabbit/oak/index/merge/IndexDiff.java
##########
@@ -192,7 +192,17 @@ private static JsonObject addParent(String key, JsonObject 
obj) {
     static JsonObject compareIndexes(String directory, String index1, String 
index2) {
         Path indexPath = Paths.get(directory);
         JsonObject target = new JsonObject(true);
-        compareIndexesIndexesInDirectory(indexPath, index1, index2, target);
+        compareIndexesInDirectory(indexPath, index1, index2, target);
+        return target;
+    }
+
+    public static JsonObject compareIndexesAgainstBase(String directory, 
String indexBaseFile) {

Review comment:
       Sure it's possible. Right now we write it to stdout here:
   
       System.out.println("Comparing indexes in " + indexBaseFile + " against 
all indexes in " +
                           " directory \"" +
                           compareDirectory + "\"");
       System.out.println(IndexDiff.compareIndexesAgainstBase(compareDirectory, 
indexBaseFile));
   
   Instead of stdout we could write it as a file to targetDirectory.
   
   ... but on the other hand, I don't need to further analyze it: for my use 
case, it is sufficient. So I argue: we can still change it quite easily once we 
need it...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to