thomasmueller commented on a change in pull request #514:
URL: https://github.com/apache/jackrabbit-oak/pull/514#discussion_r828192641
##########
File path:
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStore.java
##########
@@ -50,6 +50,16 @@ public FlatFileStore(BlobStore blobStore, File storeFile,
NodeStateEntryReader e
this.compressionEnabled = compressionEnabled;
}
+ public String getFlatFileStorePath() {
+ if (storeFile.exists() && storeFile.isFile() && storeFile.canRead()) {
+ return storeFile.getAbsolutePath();
+ }
+
+ String msg = String.format("Cannot read store file at [%s]",
+ storeFile.getAbsolutePath());
+ throw new IllegalArgumentException(msg);
Review comment:
I wonder if we could move the exception handling to the setter... Having
it in the getter is weird in my view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
