FrancoisZhang commented on a change in pull request #520:
URL: https://github.com/apache/jackrabbit-oak/pull/520#discussion_r829474833
##########
File path:
oak-run/src/main/java/org/apache/jackrabbit/oak/run/PurgeOldIndexVersionCommand.java
##########
@@ -17,17 +17,24 @@
package org.apache.jackrabbit.oak.run;
-import joptsimple.OptionParser;
-import joptsimple.OptionSet;
-import joptsimple.OptionSpec;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
import org.apache.jackrabbit.oak.indexversion.PurgeOldIndexVersion;
+import org.apache.jackrabbit.oak.run.cli.NodeStoreFixture;
+import org.apache.jackrabbit.oak.run.cli.NodeStoreFixtureProvider;
import org.apache.jackrabbit.oak.run.cli.Options;
import org.apache.jackrabbit.oak.run.commons.Command;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-import java.util.List;
-import java.util.concurrent.TimeUnit;
+import joptsimple.OptionParser;
+import joptsimple.OptionSet;
+import joptsimple.OptionSpec;
public class PurgeOldIndexVersionCommand implements Command {
+ private static final Logger LOG =
LoggerFactory.getLogger(PurgeOldIndexVersionCommand.class);
+
private long threshold;
private List<String> indexPaths;
private long DEFAULT_PURGE_THRESHOLD = TimeUnit.DAYS.toMillis(5); // 5
days in millis
Review comment:
@fabriziofortino true, i's a legacy I didn't notice that. I will refine
it together in next PR. seems need more logging here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
