Ewocker commented on code in PR #536:
URL: https://github.com/apache/jackrabbit-oak/pull/536#discussion_r853557343
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseAndSortTask.java:
##########
@@ -176,7 +181,17 @@ public List<File> call() {
return sortedFiles;
} catch (IOException e) {
- log.error(taskID + " could not complete download ", e);
+ log.error(taskID + " could not complete download with ", e);
+ } catch (Exception e) {
Review Comment:
This will not be `EOFException` because we do want to skip those, and will
catch the __merge failure__ case which originally was throwing just `Exception`
and now I change it to `RuntimeException` (correct me if there's a better
one... not sure what is correct to use here). So changing it to now catch
`RuntimeException` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
