mreutegg commented on code in PR #550:
URL: https://github.com/apache/jackrabbit-oak/pull/550#discussion_r857716136
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/LuceneJournalPropertyBuilder.java:
##########
@@ -93,6 +93,9 @@ public void addSerializedProperty(@Nullable String json) {
}
if (sizeWithinLimits()) {
indexedNodes.put(path, reader.readString());
+ } else {
+ // return if max limit reached for builder to avoid
overflow exception
+ return;
Review Comment:
The same thought crossed my mind as well when I reviewed the change but I
didn't point it out.
+1 for parsing the entire JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
