thomasmueller commented on code in PR #535:
URL: https://github.com/apache/jackrabbit-oak/pull/535#discussion_r861777038
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/SQL2Parser.java:
##########
@@ -182,6 +182,10 @@ public Query parse(final String query, final boolean
initialise) throws ParseExc
} else if (readIf("TAG")) {
options.indexTag = readLabel();
}
+ } else if (readIf("OFFSET")) {
+ q.setOffset(readNumber());
Review Comment:
So we don't support bind variable here... I think it perfectly fine: I
anyway wouldn't want people to use offset for pagination.
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryOptions.java:
##########
@@ -21,6 +21,8 @@ public class QueryOptions {
public Traversal traversal = Traversal.DEFAULT;
public String indexName;
public String indexTag;
+ public long limit = -1;
Review Comment:
Here we use magic values... Shouldn't we use Optional as well here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
