[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #552: OAK-9753: ES connection parameters should be easily accessible from ElasticConnectionRule

[GitBox]

tihom88 commented on code in PR #552:
URL: https://github.com/apache/jackrabbit-oak/pull/552#discussion_r865603102


##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexCleanerTest.java:
##########
@@ -75,9 +75,9 @@ public void testIndexDeletion() throws Exception {
         assertTrue(exists(indexId3));
 
         Thread.sleep(5000);
-        cleaner.run();
 
         assertEventually(() -> {
+            cleaner.run();

Review Comment:
   removed this file from commit. 



##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java:
##########
@@ -186,4 +263,37 @@ private void setUseDocker(boolean useDocker) {
     public boolean useDocker() {
         return useDocker;
     }
+
+    public class ElasticConnectionConnectionModel {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org