nit0906 commented on code in PR #564:
URL: https://github.com/apache/jackrabbit-oak/pull/564#discussion_r869886843
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -251,7 +238,7 @@ public void reindex() throws CommitFailedException,
IOException {
closer.register(indexer);
- FlatFileStore flatFileStore = buildFlatFileStore(checkpointedState,
indexer);
+ FlatFileStore flatFileStore = buildFlatFileStore(checkpointedState,
indexer, indexer::shouldInclude, null);
Review Comment:
just a nit pick.
this seems redundant since we are already using the same predicate in line
161 too in case the pathPredicate passed to that method is null.
I think either one of these could be removed (I don't have a strong opinion
around this though.)
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -251,7 +238,7 @@ public void reindex() throws CommitFailedException,
IOException {
closer.register(indexer);
- FlatFileStore flatFileStore = buildFlatFileStore(checkpointedState,
indexer);
+ FlatFileStore flatFileStore = buildFlatFileStore(checkpointedState,
indexer, indexer::shouldInclude, null);
Review Comment:
just a nit pick.
this seems redundant since we are already using the same predicate in line
161 too in case the pathPredicate passed to that method is null.
I think either one of these could be removed (I don't have a strong opinion
around this though.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
