fabriziofortino commented on code in PR #565:
URL: https://github.com/apache/jackrabbit-oak/pull/565#discussion_r869931690
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticMetricHandler.java:
##########
@@ -50,15 +50,13 @@ public class ElasticMetricHandler {
private final BiFunction<String, Map<String, String>, MeterStats> meter;
private final BiFunction<String, Map<String, String>, HistogramStats>
histogram;
private final BiFunction<String, Map<String, String>, TimerStats> timer;
+ private final StatsProviderUtil statsProviderUtil;
Review Comment:
minor: extra space
```suggestion
private final StatsProviderUtil statsProviderUtil;
```
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/hybrid/NRTIndex.java:
##########
@@ -94,6 +96,8 @@ public class NRTIndex implements Closeable {
private List<LuceneIndexReader> readers;
private final List<IndexReader> openedReaders;
private final boolean assertAllReadersClosed;
+ private final StatsProviderUtil statsProviderUtil;
+ private Map<String, String> labels;
Review Comment:
this could be final too
```suggestion
private final Map<String, String> labels;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
