tihom88 commented on code in PR #573:
URL: https://github.com/apache/jackrabbit-oak/pull/573#discussion_r875746213


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java:
##########
@@ -228,11 +231,21 @@ protected String getDefaultFunctionName() {
     /**
      * Returns {@code true} if original terms need to be preserved at indexing 
analysis phase
      */
-    public boolean indexOriginalTerms() {
+    public boolean analyzerConfigIndexOriginalTerms() {
         NodeState analyzersTree = definition.getChildNode(ANALYZERS);
         return getOptionalValue(analyzersTree, INDEX_ORIGINAL_TERM, false);

Review Comment:
   For lucene this is true. I think we should change it's default value to 
true, so that index definition for lucene and ES remain same WRT analyzers.
   
   
https://github.com/apache/jackrabbit-oak/blob/4f99576158aa9b190879291d79002e20aef28ee4/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/OakAnalyzer.java#L69
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to