fabriziofortino commented on code in PR #568:
URL: https://github.com/apache/jackrabbit-oak/pull/568#discussion_r876381584
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexProviderServiceTest.java:
##########
@@ -95,6 +96,8 @@ public void defaultSetup() {
@Test
public void withElasticSetup() throws Exception {
+ // Skips this test when a single Elasticsearch cluster is re-used
among test executionsgit , see the ElasticTestServer main.
+ assumeTrue(elasticRule.useDocker());
Review Comment:
That's not correct: the tests need to work also with single ES clusters.
Please revert these changes. To fix the problem lines 105 and 124 need to be
replaced with (I have tried to push the commit myself but I have problem s with
this branch):
```java
props.put(PROP_ELASTIC_PORT,
elasticRule.getElasticConnectionModel().getElasticPort());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
