kwin commented on PR #228: URL: https://github.com/apache/jackrabbit-filevault/pull/228#issuecomment-1156685609
> With that you can remove testGenericJcrDataWithBinaryFileDetected() as this should now be covered by testGenericJcrData() already. Right, gonna remove the former. > I don't understand how these changes are related https://github.com/apache/jackrabbit-filevault/pull/228/files#diff-d467e47245ea852f2e8ae6cc036e413bc2098a0e5be790a56eb238e3a17f3b41R375-R383 The problem was that `testGenericJcrDataWithBinaryFileDetected()` was never failing for me when called from the IDE, as in that case the validators `genericjcrdataid2` and `jackrabbit-docviewparser` had the wrong order (the latter must always come first). As the new map originally didn't retain any order, this fix was necessary to make the test and probably also the validation at runtime always behave the same (irrespective of underlying Map implementations). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
