[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #606: OAK-9816: add max rows read data to table

Mon, 27 Jun 2022 02:50:02 -0700 


thomasmueller commented on code in PR #606:
URL: https://github.com/apache/jackrabbit-oak/pull/606#discussion_r907171595


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/stats/QueryStatsMBeanImpl.java:
##########
@@ -218,8 +218,8 @@ private static class QueryStatsCompositeTypeFactory {
         private final static OpenType[] types = { SimpleType.LONG,
                 SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
                 SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
-                SimpleType.STRING, SimpleType.STRING, SimpleType.STRING,
-                SimpleType.STRING};
+                SimpleType.LONG, SimpleType.STRING, SimpleType.STRING, 

Review Comment:
   It's a bit hard to know which entry matches which entry of the "names" 
list... 
   
   Could we use newlines at the same positions, in both lists? We have 4 
entries with String, those could all be on one line. And for the rest, use 3 
per line.
   
   Or, we could somehow make it more structured...



##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/stats/QueryStatsMBeanImpl.java:
##########
@@ -218,8 +218,8 @@ private static class QueryStatsCompositeTypeFactory {
         private final static OpenType[] types = { SimpleType.LONG,
                 SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
                 SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
-                SimpleType.STRING, SimpleType.STRING, SimpleType.STRING,
-                SimpleType.STRING};
+                SimpleType.LONG, SimpleType.STRING, SimpleType.STRING, 

Review Comment:
   New:
   
   "position", 
   "maxTimeMillis", "totalTimeMillis", "executeCount", 
   "rowsRead", "rowsScanned", "maxRowsRead", "maxRowsScanned",
   "language", "statement", "lastExecuted",
   "lastThread"
   
   SimpleType.LONG,
   SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
   SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
   SimpleType.STRING, SimpleType.STRING,  SimpleType.STRING, 
   SimpleType.STRING};



##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/stats/QueryStatsMBeanImpl.java:
##########
@@ -218,8 +218,8 @@ private static class QueryStatsCompositeTypeFactory {
         private final static OpenType[] types = { SimpleType.LONG,
                 SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
                 SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
-                SimpleType.STRING, SimpleType.STRING, SimpleType.STRING,
-                SimpleType.STRING};
+                SimpleType.LONG, SimpleType.STRING, SimpleType.STRING, 

Review Comment:
   Old:
   
    "position", 
    "maxTimeMillis", "totalTimeMillis", "executeCount", 
    "rowsRead", "rowsScanned", "maxRowsScanned",
    "language", "statement", "lastExecuted",
    "lastThread"
   
    SimpleType.LONG,
    SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
    SimpleType.LONG, SimpleType.LONG, SimpleType.LONG, 
    SimpleType.STRING, SimpleType.STRING, SimpleType.STRING,
    SimpleType.STRING};



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to