nit0906 commented on code in PR #615:
URL: https://github.com/apache/jackrabbit-oak/pull/615#discussion_r917784352
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java:
##########
@@ -60,6 +60,7 @@ class ElasticBulkProcessorHandler {
private static final Logger LOG =
LoggerFactory.getLogger(ElasticBulkProcessorHandler.class);
private final int FAILED_DOC_COUNT_FOR_STATUS_NODE =
Integer.getInteger("oak.failedDocStatusLimit", 10000);
+ private static final int BULK_PROCESSOR_CONCURRENCY = 4;
Review Comment:
This PR should not be changing ElasticBulkProcessorHandler like this, since
this would directly impact async indexing as well.
If we need to have a BP concurrency here, I suggest we make this
configurable and set it via the oak-run OutOfIndexing flow (which this PR
targets) and keep the default concurrency to 1 (i.e no concurrency).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
