[
https://issues.apache.org/jira/browse/JCRVLT-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566357#comment-17566357
]
Konrad Windszus edited comment on JCRVLT-644 at 7/13/22 2:54 PM:
-----------------------------------------------------------------
The change was introduced with
https://github.com/apache/jackrabbit-filevault/commit/81245c26caa138b883010fefd66a96938b6bb84f#diff-1e61b31374ccb99480e94034d365dd1b79018b6f54316d2fd2bfdc37eeb4a07cL99
(JCRVLT-357) for {{isStrict = false}}. Prior the commit the SAXException was
just caught in {{GenericArtifactHandler}} and lead to setting the error flag.
After the commit it was wrapped as {{XmlParseException}} which was again
wrapped as {{RepositoryException}} (funnily the latter always happened in
https://github.com/apache/jackrabbit-filevault/blob/5f3b1d363da7bcf3c285a0bdbb394254ca3e57d1/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L243
and
https://github.com/apache/jackrabbit-filevault/blob/5f3b1d363da7bcf3c285a0bdbb394254ca3e57d1/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L344
for the {{FileArtifactHandler}}).
was (Author: kwin):
The change was introduced with
https://github.com/apache/jackrabbit-filevault/commit/81245c26caa138b883010fefd66a96938b6bb84f#diff-1e61b31374ccb99480e94034d365dd1b79018b6f54316d2fd2bfdc37eeb4a07cL99
(JCRVLT-357) for {{isStrict = false}}. Prior the SAXException was just caught
in {{GenericArtifactHandler}} and lead to setting the error flag. Afterwards it
was wrapped as {{XmlParseException}} which was again wrapped as
{{RepositoryException}} (funnily the latter always happened in
https://github.com/apache/jackrabbit-filevault/blob/5f3b1d363da7bcf3c285a0bdbb394254ca3e57d1/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L243
and
https://github.com/apache/jackrabbit-filevault/blob/5f3b1d363da7bcf3c285a0bdbb394254ca3e57d1/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L344
for the {{FileArtifactHandler}}).
> Import of package with not well-formed DocViews behaves differently since
> 3.6.0 for isStrict = false
> ----------------------------------------------------------------------------------------------------
>
> Key: JCRVLT-644
> URL: https://issues.apache.org/jira/browse/JCRVLT-644
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: vlt
> Reporter: Julian Reschke
> Assignee: Konrad Windszus
> Priority: Major
>
> It appears that the behavior for packages containing broken content.xml
> entries changed in (ca.) version 3.5.2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
