kwin commented on code in PR #592:
URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r937992571


##########
oak-parent/pom.xml:
##########
@@ -34,6 +34,8 @@
   <packaging>pom</packaging>
 
   <properties>
+    <minimalMavenBuildVersion>3.3.9</minimalMavenBuildVersion>
+    <maven.compiler.target>1.8</maven.compiler.target>

Review Comment:
   Yes, good point, although `java.version` is a poor name for a Maven Property 
as there is also the same named [Java system 
property](https://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html):
 https://maven.apache.org/pom.html#properties but that is a different 
discussion....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to