rombert commented on code in PR #629:
URL: https://github.com/apache/jackrabbit-oak/pull/629#discussion_r943361926
##########
oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/checks/ErrorHolder.java:
##########
@@ -27,16 +27,16 @@ class ErrorHolder {
private static final int FAIL_IMMEDIATELY_THRESHOLD = 100;
private final List<String> errors = new ArrayList<>();
- public void report(MountedNodeStore mountedStore, String path, String
error) {
- errors.add(String.format("For NodeStore mount %s, path %s, encountered
the following problem: '%s'", mountedStore.getMount().getName(), path, error));
+ public void report(MountedNodeStore mountedStore, String path, String
error, MountedNodeStoreChecker<?> checker) {
Review Comment:
I think 'not versioned but exported' is the general Oak policy. I don't
agree, but this is what we settled on.
For this particular change I have no backwards compatibility concerns since
I did not see any exported APIs changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
