thomasmueller commented on code in PR #667: URL: https://github.com/apache/jackrabbit-oak/pull/667#discussion_r946860103
########## oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/util/QueryUtils.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.jackrabbit.oak.plugins.index.search.util; + +public class QueryUtils { + + public static final char WILDCARD_STRING = '*'; + public static final char WILDCARD_CHAR = '?'; + public static final char WILDCARD_ESCAPE = '\\'; + + private static void replaceWildcard(StringBuilder sb, int position, char oldWildcard, char newWildcard) { Review Comment: My recommendation would be: Replace a wildcard character, unless if it's escaped. There are multiple cases: - it is not escaped - it is escaped - there are two escape characters before the wildcard, in which case the escape character is escaped and not the wildcard - there are even more escape characters before the wildcard, in which case it depends on whether the number of escape characters is even or odd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
