fabriziofortino commented on code in PR #670:
URL: https://github.com/apache/jackrabbit-oak/pull/670#discussion_r949228992
##########
oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/FullTextIndexCommonTest.java:
##########
@@ -45,12 +48,12 @@ public void defaultAnalyzer() throws Exception {
root.commit();
assertEventually(() -> {
- assertQuery("//*[jcr:contains(@analyzed_field, 'SUN.JPG')] ",
XPATH, Collections.singletonList("/test/a"));
- assertQuery("//*[jcr:contains(@analyzed_field, 'Sun')] ", XPATH,
Collections.singletonList("/test/a"));
- assertQuery("//*[jcr:contains(@analyzed_field, 'jpg')] ", XPATH,
Collections.singletonList("/test/a"));
- assertQuery("//*[jcr:contains(., 'SUN.jpg')] ", XPATH,
Collections.singletonList("/test/a"));
- assertQuery("//*[jcr:contains(., 'sun')] ", XPATH,
Collections.singletonList("/test/a"));
- assertQuery("//*[jcr:contains(., 'jpg')] ", XPATH,
Collections.singletonList("/test/a"));
+ assertQuery("//*[jcr:contains(@analyzed_field, 'SUN.JPG')] ",
XPATH, singletonList("/test/a"));
+ assertQuery("//*[jcr:contains(@analyzed_field, 'Sun')] ", XPATH,
singletonList("/test/a"));
+ assertQuery("//*[jcr:contains(@analyzed_field, 'jpg')] ", XPATH,
singletonList("/test/a"));
+ assertQuery("//*[jcr:contains(., 'SUN.jpg')] ", XPATH,
singletonList("/test/a"));
Review Comment:
@nit0906 I did not notice this because the test console output does not
include log messages.
I have converted this PR to `draft` and I do not plan to merge it. I have
improved a bit the logging in case of failure starting from the work done in
https://github.com/apache/jackrabbit-oak/pull/649/files#diff-ac2f41f4e63cb259a78a57e764daed1a88e5a1d225161398ee16cc7db60a4034
I have mainly centralized the message in a new Exception avoiding printing
the different information in multiple places.
@nfsantos please review this and incorporate this work in the main OAK-9875
PR. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
