rishabhdaim commented on code in PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#discussion_r967205310
########## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/ModifyMetricUpdater.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.jackrabbit.oak.plugins.document.util; + +import org.apache.jackrabbit.oak.plugins.document.Collection; +import org.apache.jackrabbit.oak.plugins.document.Document; +import org.apache.jackrabbit.oak.plugins.document.DocumentStore; +import org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsCollector; +import org.apache.jackrabbit.oak.stats.MeterStats; +import org.apache.jackrabbit.oak.stats.TimerStats; + +import java.util.function.Consumer; +import java.util.function.ObjIntConsumer; +import java.util.function.Predicate; + +import static java.util.Objects.requireNonNull; + +/** + * Abstract class to update the metrics for {@link DocumentStoreStatsCollector#doneFindAndModify(long, Collection, String, boolean, boolean, int)} for underlying {@link DocumentStore} + * + * <p>Concrete implementations provide instances of {@link MeterStats}, {@link TimerStats} based on whether throttling is ongoing or not + */ +public abstract class ModifyMetricUpdater { + + private final MeterStats createNodeUpsertMeter; + private final TimerStats createNodeUpsertTimer; + private final MeterStats updateNodeMeter; + private final TimerStats updateNodeTimer; + private final MeterStats updateNodeRetryCountMeter; + private final MeterStats updateNodeFailureMeter; + + public ModifyMetricUpdater(final MeterStats createNodeUpsertMeter, + final TimerStats createNodeUpsertTimer, + final MeterStats updateNodeMeter, + final TimerStats updateNodeTimer, + final MeterStats updateNodeRetryCountMeter, + final MeterStats updateNodeFailureMeter) { + this.createNodeUpsertMeter = createNodeUpsertMeter; + this.createNodeUpsertTimer = createNodeUpsertTimer; + this.updateNodeMeter = updateNodeMeter; + this.updateNodeTimer = updateNodeTimer; + this.updateNodeRetryCountMeter = updateNodeRetryCountMeter; + this.updateNodeFailureMeter = updateNodeFailureMeter; + } + + public void update(final Collection<? extends Document> collection, final int retryCount, + final long timeTakenNanos, final boolean isSuccess, final boolean newEntry, + final Predicate<Collection<? extends Document>> isNodesCollection, + final StatsConsumer<MeterStats, TimerStats> createStatsConsumer, + final StatsConsumer<MeterStats, TimerStats> updateStatsConsumer, + final ObjIntConsumer<MeterStats> retryNodesConsumer, + final Consumer<MeterStats> failureNodesConsumer) { + + requireNonNull(isNodesCollection); + requireNonNull(createStatsConsumer); + requireNonNull(updateStatsConsumer); + requireNonNull(retryNodesConsumer); + requireNonNull(failureNodesConsumer); + + if (isNodesCollection.negate().test(collection)) {return;} Review Comment: Sure, will update the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
