nfsantos commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978566806
########## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ########## @@ -16,18 +16,25 @@ */ package org.apache.jackrabbit.oak.plugins.index.elastic.index; +import co.elastic.clients.elasticsearch._types.Time; +import co.elastic.clients.elasticsearch._types.mapping.Property; +import co.elastic.clients.elasticsearch._types.mapping.TypeMapping; +import co.elastic.clients.elasticsearch.indices.CreateIndexRequest; +import co.elastic.clients.elasticsearch.indices.IndexSettings; +import co.elastic.clients.json.JsonData; +import co.elastic.clients.util.ObjectBuilder; +import jakarta.json.Json; +import jakarta.json.JsonObject; +import jakarta.json.JsonValue; import org.apache.jackrabbit.oak.api.Type; import org.apache.jackrabbit.oak.plugins.index.elastic.ElasticIndexDefinition; import org.apache.jackrabbit.oak.plugins.index.elastic.ElasticPropertyDefinition; import org.apache.jackrabbit.oak.plugins.index.search.FieldNames; import org.apache.jackrabbit.oak.plugins.index.search.PropertyDefinition; import org.elasticsearch.action.admin.indices.settings.put.UpdateSettingsRequest; -import org.elasticsearch.client.indices.CreateIndexRequest; import org.elasticsearch.common.settings.Settings; -import org.elasticsearch.xcontent.XContentBuilder; -import org.elasticsearch.xcontent.XContentFactory; +import org.jetbrains.annotations.NotNull; Review Comment: I don't find any usage of the javax NotNull in Oak, I don't think we even import the package that defines this annotation. We only use the Jetbrains NotNull annotation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
