kwin commented on code in PR #245:
URL:
https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979279113
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -1200,28 +1200,37 @@ private boolean isPropertyProtected(@NotNull
EffectiveNodeType effectiveNodeType
return
effectiveNodeType.getApplicablePropertyDefinition(npResolver.getJCRName(docViewProperty.getName()),
docViewProperty.isMultiValue(),
docViewProperty.getType()).map(PropertyDefinition::isProtected).orElse(false);
}
+ private String getLexicalForm(Name name) throws RepositoryException {
Review Comment:
IMHO this additional lookup costs some performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
